Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making compatible with CommonJS for browserify/webpack #233

Merged
merged 1 commit into from Aug 28, 2015

Conversation

jslatts
Copy link
Contributor

@jslatts jslatts commented Aug 28, 2015

This change checks to see if the module is getting loaded in a CommonJS environment (AKA browserify/webpack) and acts appropriately.

This is related to #231, though it only partially resolves the problem.

You still cannot load this module server-side due to the dependency on jquery.extend, as jquery doesn't load without a window object.

rmm5t added a commit that referenced this pull request Aug 28, 2015
Making compatible with CommonJS for browserify/webpack
@rmm5t rmm5t merged commit fbd7334 into rmm5t:master Aug 28, 2015
@rmm5t
Copy link
Owner

rmm5t commented Aug 28, 2015

Thanks! v1.4.2 is now released and published to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants