Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow for options on 0.11.2 #77

Open
wants to merge 11 commits into
from

Conversation

Projects
None yet
3 participants

Allow for options to be passed in to timeago for 0.11.2. Used code from pull/24

Owner

rmm5t commented May 14, 2012

Thanks for this, but at first glance, it appears to break the test suite. I think it's because the settings argument isn't always optional.

Can you direct me on how to run the test suite so I can take a look at it?

Owner

rmm5t commented May 14, 2012

open test/index.html

This seems like a good PR, because on the same page, I might have to different instances of timeago I want to handle. E.g.

  1. A grid where I show the last login date of a user. In this case, I want to see "About 21 hours ago" in a column. Note: the A in About is uppercase because it starts a sentence.
  2. On the same page I want to see audit logs of the creation of users. E.g., I want to see "Jon created a new user about 5 minutes ago". Note: the a in about is lowercase because it's in a sentence.

Perhaps you can do this already and I just can't find the docs, but it seems that enabling custom settings per timeago instance would be great.

I fixed the test suite not passing and updated to 11.4. Let me know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment