Pulling latest changes from pmd/pmd: 12/15/2020 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] Fix XMLRenderer newlines when running under IBM Java #2831
[vf] Allow attributes with dot in Visualforce #2834
[core] Bump antlr4 from 4.7 to 4.7.2 #2842
[apex] Detect 'Database' method invocations inside loops #2816
Addresses the general issue raised in #1092 This commit removes false positives from expressions in apex tags. The specific use case raised in 1092 isn't reproducible and represents a false negative that will be fixed separately. The existing Visualforce rules don't have any information about the data types referenced in the Visualforce page. This results in false positives when attempting to identify expressions that are vulnerable to XSS attacks. The rules should not warn about XSS attacks when the expression refers to a type such as Integer or Boolean. The VfExpressionTypeVisitor visits the Visualforce page and extracts the datatypes from Salesforce metadata. Data type information can come from either Apex classes or Object Fields. The Salesforce metadata is generally located in a sibling directory of the Visualforce directory. By default the code looks in directories relative to the Visualforce file to find the metadata. The conventional locations for the metadata are "../classes" and "../objects", the user can override this default with other directories if required.
Since the default minimum is 30, I believe it would make more sense if the comment said "28" instead of "18".
Docs of CouplingBetweenObjects has a Programming issue. I also made "something" a method.
[java] (doc) Update ExcessiveImports example code for clarity #2865
[java] (doc) Fix example for CouplingBetweenObjects #2866
[apex] Add support for Safe Navigation Operator (v50, Winter 21) #2863
This DataType does not need to be escaped, it is always escaped by the server.
[core] New RuleSet API and deprecations for PMD's entry point APIs #2635
The same problem would have occurred for the release build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)