Decode the README as utf-8 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tox no longer passed environment variables from the calling environment. This causes problems, because the LANG environment variable is how Python attempts to figure out the locale, and defaults to ASCII. The README file has utf-8 characters. This means that right now this package cannot be installed under tox 2 with Python 3, unless tox in configured to pass that environment variable from the context.
Put all the testing configuration and various python versions to test in tox.ini, and use TOXENV to choose which one to build on Travis. Use Travis' build matrix to separate the runs for all of the tox envs. The sudo: false line should speed up the builds, because it allows Travis to use containers.
|
I'm seeing the same issue, and this fix worked for me. More people are going to get tox 2 and see it in TravisCI. An alternate is to use: from io import open # Python 3's open, in Python 2.6 and above
long_description=open('README.rst', 'r', encoding='utf-8') |
|
It is another solution. I chose this one because it doesn't require another import, and I understand based on a stack overflow answer than the io import is slower too. |
|
A terrible workaround for individual projects can be to add |
|
Hi, Thank you for bringing this to my attention! I do not care very much how the encoding is set. So the version from @ryanhiebert is fine for me. I also like the new tox configuration very much. @ryanhiebert @jwhitlock thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox, in version 2, no longer passes environment variables from the calling environment. This causes problems, because the
LANGenvironment variable is how Python attempts to figure out the locale, and defaults to ASCII. TheREADME.rstfile has utf-8 characters, and is read in thesetup.py.This means that right now this package cannot be installed under tox 2 with Python 3, unless tox is configured to pass that environment variable from the context.
Running the tests on Travis CI isn't catching this, because this problem doesn't show up without a limited environment, like we get from tox.