using production react #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rmosolgo, maybe you have some insight into this? Cheers Mate! |
|
Hey! Sorry about this issue. There's no good reason to use the development version, but I think we need to update the build scripts too: https://github.com/rmosolgo/graphiql-rails/blob/master/Rakefile#L14 That script bumps the graphiql version and its dependencies automatically. I think we should that too, or else the next update will put the development version in place 馃槚 . Want to give it a try? |
updating rake and re updating GraphiQL & dependencies
gregology
force-pushed
the
using_prod_react
branch
from
aae31fa
to
ba48cd5
Compare
|
@rmosolgo, neat rake task! Done, do you want me to squash? |
|
Awesome, thanks! |
|
馃殺 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this gem is using development react which is giving me this error
Is there a reason to use development react instead of production in this instance? If not, here's a quick PR to update it to the production 0.16.0 release.
Cheers Team!