Update GraphiQL & React, and use graphiql.min.{js,css} assets
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bundle exec rake update_graphiql`
This version does not include Webpack's inline source mapping, which uses eval and may conflict with the host application's Content Security Policy.
|
Hey, thanks for these updates. I'm going to merge them then continue with a new update of these assets 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the vendored dependencies
graphiql2.4.02.4.1Updates on original version of this PR
react16.14.017.0.2react-dom16.14.017.0.2graphiql1.4.21.5.17and switches to using the minified version of the
graphiqlassets, which do not include Webpack's inline source maps, which require'unsafe-eval'to be in the Content Security Policy of the host app.Note that GraphiQL's
.min.jsstill makes use ofnew Function("return this;"), meaning it still requires'unsafe-eval', but that needs to be solved upstream. If that happens, we'll simply need to runrake update_graphiqlagain to get the fixed version.This should contribute towards better addressing #46, rather than forcing the host app to loosen its Content Security Policy.