Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10] Schema.build_from_definition should make classes #2178

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Mar 9, 2019

This is a pretty big change for anyone using .from_definition to build their schemas. Now, .from_definition builds a class-based schema out of dynamically-created, anonymous classes.

That means, at least, that the ctx passed into resolvers will be a GraphQL::Query::Context instead of a GraphQL::Query::Context::FieldResolutionContext. Resolvers won't have access to metadata anymore. Maybe we'll need a followup to somehow support extras.

@rmosolgo rmosolgo mentioned this pull request Mar 9, 2019
14 tasks
@rmosolgo rmosolgo changed the base branch from master to 1.10-dev March 27, 2019 18:01
@rmosolgo rmosolgo added this to the 1.10.0 milestone Mar 28, 2019
@rmosolgo rmosolgo merged commit b97f64d into 1.10-dev Mar 28, 2019
@rmosolgo rmosolgo deleted the schema-build-from-definition-class-based branch March 28, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant