[1.10] Schema.build_from_definition should make classes #2178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big change for anyone using
.from_definition
to build their schemas. Now,.from_definition
builds a class-based schema out of dynamically-created, anonymous classes.That means, at least, that the
ctx
passed into resolvers will be aGraphQL::Query::Context
instead of aGraphQL::Query::Context::FieldResolutionContext
. Resolvers won't have access to metadata anymore. Maybe we'll need a followup to somehow supportextras
.