Issue#2067 Replace NotImplementedError with RequiredImplementationMissingError #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmosolgo
approved these changes
Oct 15, 2019
| @@ -66,7 +66,7 @@ def initialize_copy(other) | |||
|
|
|||
| # @return [Symbol] the method to call on {Language::Visitor} for this node | |||
| def visit_method | |||
| raise NotImplementedError, "#{self.class.name}#visit_method shold return a symbol" | |||
| raise GraphQL::RequiredImplementationMissingError, "#{self.class.name}#visit_method shold return a symbol" | |||
There was a problem hiding this comment.
Suggested change
| raise GraphQL::RequiredImplementationMissingError, "#{self.class.name}#visit_method shold return a symbol" | |
| raise GraphQL::RequiredImplementationMissingError, "#{self.class.name}#visit_method should return a symbol" |
Unrelated to your change, but I couldn't help noticing it! 🙈
There was a problem hiding this comment.
Nevermind, I thought I could commit changes from the comment, but it's not working 🤷♂
There was a problem hiding this comment.
Sorry, I didn't notice this typo 🤦♂
I can prepare a fix for that as well 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2067