Ably robustness improvements #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures Prettier 1.x is used for formatting.
- Refactor to be async - Fix unsubscribe call (cf. ably/ably-js#667) - Report missing X-Subscription-ID header - Report errors when entering presence - Report errors during leave or detach - Wait for leave and detach to complete before releasing channel
|
Awesome, thanks for the improvements here. (🙈 My production experience is with Pusher, which does not have as many lifecycle steps!) |
|
🚢 in 1.7.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsubscribecall (cf. Bad type declaration for RealtimeChannelBase.unsubscribe ably/ably-js#667)X-Subscription-IDheaderThe last item is the main reason for this PR. Currently, the ack messages that Ably sends back especially for detach won't be processed correctly because by the time they arrive, the channel has already been released and Ably can't find it in its mapping. I think this should be harmless but there is a chance this is causing problems.
The code could be a lot nicer if we could use
Ably.Promise, but that would be a breaking change so I left it for another day.