Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON's generate+quirks_mode to allow dumping scalar values #316

Merged
merged 1 commit into from
Oct 16, 2016
Merged

Use JSON's generate+quirks_mode to allow dumping scalar values #316

merged 1 commit into from
Oct 16, 2016

Conversation

astorije
Copy link
Contributor

From #306 (comment):

One more thing, I'd like to get the JSON-related changes in master. Recently, someone else reported a bug for that, where another JSON implementation was 馃挜-ing.

Exported from #306. This was failing on Ruby 1.9.3 as well.

@astorije astorije mentioned this pull request Oct 16, 2016
Closed
@rmosolgo
Copy link
Owner

馃憤 Awesome, I think this will also fix rmosolgo/graphiql-rails#14 !

@rmosolgo rmosolgo merged commit 28998fe into rmosolgo:master Oct 16, 2016
@rmosolgo rmosolgo mentioned this pull request Oct 16, 2016
Closed
@astorije astorije deleted the astorije/fix-json branch October 16, 2016 15:04
@rmosolgo rmosolgo modified the milestone: 0.19.4 Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@astorije @rmosolgo