graphql-c_parser: Properly register global variables #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: rmosolgo#4640 `GraphQL_Language_Nodes_` are global variables and their value is assigned the return value of `const_get` which contrary to `rb_define_class_*` isn't pinned. So they must be registered with `rb_global_variable`. On a side note, `rb_global_variable` must be called before the variable is assigned, not after.
|
Thanks for fixing this! I thought, since |
|
released in graphql-c_parser 1.0.7 |
Yeah, that's the tricky part here. You don't need to register them again to prevent them from being garbage collected because they are referenced elsewhere. But on our CI we compact the heap with |
peterzhu2118
added a commit
to Shopify/yjit-bench
that referenced
this pull request
Nov 28, 2023
The gem has a bug with compaction that was fixed in rmosolgo/graphql-ruby#4641.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4640
GraphQL_Language_Nodes_are global variables and their value is assigned the return value ofconst_getwhich contrary torb_define_class_*isn't pinned.So they must be registered with
rb_global_variable.On a side note,
rb_global_variablemust be called before the variable is assigned, not after.