-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ink 4.0.0 #49
Conversation
the CI is failing. Make update to github workflow. Example here |
#[cfg_attr( | ||
feature = "std", | ||
derive(scale_info::TypeInfo, ink_storage::traits::StorageLayout) | ||
derive(scale_info::TypeInfo, ink::storage::traits::StorageLayout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is StorageLayout
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we still need storage layout for the types - fails to compile without them.
crates/equippable/src/traits.rs
Outdated
@@ -3,7 +3,7 @@ use rmrk_common::{ | |||
errors::Result, | |||
types::*, | |||
}; | |||
// use ink_prelude::vec::Vec; | |||
// use ink::prelude::vec::Vec; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete?
examples/equippable/Cargo.toml
Outdated
rmrk = { path = "../../crates/rmrk", default-features = false } | ||
|
||
|
||
|
||
[lib] | ||
name = "rmrk_example_equippable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
is not needed any more
examples/mintable/Cargo.toml
Outdated
rmrk = { path = "../../crates/rmrk", default-features = false } | ||
|
||
|
||
[lib] | ||
name = "rmrk_example_mintable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.