Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarking: update all benchmark tests for functions using budget #241

Closed
2 of 3 tasks
ilionic opened this issue Nov 6, 2022 · 2 comments · Fixed by #254
Closed
2 of 3 tasks

Benchmarking: update all benchmark tests for functions using budget #241

ilionic opened this issue Nov 6, 2022 · 2 comments · Fixed by #254

Comments

@ilionic
Copy link
Contributor

ilionic commented Nov 6, 2022 •
edited
Loading

  • burn_nft
  • reject_nft ( since using burning )
  • all calls using root owner lookup
@ilionic ilionic mentioned this issue Nov 6, 2022
Merged
@Szegoo
Copy link
Contributor

Szegoo commented Dec 9, 2022

@ilionic I would like to update the other benchmarks that use root owner lookup if no one else is working on this.

@ilionic
Copy link
Contributor Author

ilionic commented Dec 9, 2022

Sounds good, @Szegoo. Thanks

@Szegoo Szegoo mentioned this issue Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update benchmarks that use lookup_root_owner Szegoo/rmrk-substrate
2 participants
@ilionic @Szegoo