Add TransferHooks, Budget fix and upgrade to Polkadot v0.9.33 #256
Conversation
…s for implementation downstream for custom logic
Upgrade to polkadot-v0.9.33 & Add checkAllowTransferFn Trait
…when Nesting child NFTs to a parent.
Fix budget issue with Nested NFTs
| fn budget_left_value(&self) -> u32 { | ||
| self.get_budget_left_value() |
There was a problem hiding this comment.
A better name for this may be budget_remaining_value.
There was a problem hiding this comment.
I've seen cases for both namings. We currently use it in production for Phala, but I can make the change if we want to use remaining vs left
There was a problem hiding this comment.
If we already use it in production for Phala it is probably better to keep it then.
There was a problem hiding this comment.
@ilionic can weigh-in on this. The change isn't too major, so I think it should be okay if there is a preference and we will make updates through runtime upgrade in the future.
|
I'm gonna create another PR to update to |
|
Closing in favor of #259 |
Description
TransferHooks implementation
For implementations downstream of the RMRK pallet there needs to be an ability to add custom logic in the case that there are multiple pallets using the RMRK NFT pallet, but want to keep the business logic mutually exclusive. This implementation allows for a trait called
TransferHooksto be implemented with 2 functionspre_checkandpost_transferthat default totruewhen not implemented.Budget trait fix
There are 2 problems with the current Budget trait:
NFTs are currently allowed to mint and send NFTs to a parent NFT that can meet up to the threshold of NestingBudget::get() + 1. This allows for NFTs queries like lookup_root_owner to return errors like TooManyRecursions. Having this error is okay, but the NFTs should be prevented from being minted to or sent to a parent NFT if the Budget threshold is met.
Currently the code will do a calculation on functions like burn_nft and this will perform an arithmetic subtraction at the end of the function, but this should be added as a field in the Value type & implement a function from Budget to get the budget that has been consumed and budget that is left.
Targets
polkadot-v0.9.33TransferHookstrait withpre_checkandpost_transferfunctionsNestingBudget::get()value.budget_consumedand budget_left` to track & through errors is an overflow is detected.Budgettrait to get the 2 new fields.