Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read project vars for compileSdkVersion, et al #28

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

abonander
Copy link
Contributor

Following this convention helps prevent headache-inducing build errors from version mismatches.

@erezrokah
Copy link
Member

Hey @abonander and thanks for the pr :)

Do you mind describing (maybe opening) the issue that this pr fixes (an example repo will be perfect)?
It is hard for me to understand the changes this way.

Also will this change the existing defaults for the project values?

@abonander
Copy link
Contributor Author

I put the defaults back, that was a mistake.

This is important when a project wants to specify different versions for these parameters, as having dependencies with differing versions can cause build errors. It is especially important to have compileSdkVersion match the version of any support libraries that are being linked. The user will define these variables in their top-level build.gradle: https://developer.android.com/studio/build/gradle-tips#configure-project-wide-properties

This is a convention that other packages are already following (the code is equivalent):

@erezrokah erezrokah merged commit 9f17f23 into rmrs:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants