This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Screw up scrapper #4257
Merged
shenlebantongying
merged 1 commit into
rms-support-letter:master
from
powerboat9:patch-1
Mar 29, 2021
Merged
Screw up scrapper #4257
shenlebantongying
merged 1 commit into
rms-support-letter:master
from
powerboat9:patch-1
Mar 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screws up the scrapper at https://gist.github.com/kyhwana/73161a50d1b5019b18e3965b55a1a192 using a spider trap. Should screw up some other curl based scrappers.
Approved! |
Can you inject |
I don't think so. The way xargs is used, the only thing you can really do is screw with the url parameter curl gets. You could try using a name starting with "../../" to call a different api function, though you'd have to find an api function that takes the same parameters in a POST request. |
They seem to have adapted to this hack in a fork... |
Won't that break some links? Like |
yes, reverted |
Thanks for fixing. |
Looking at that scraper, we could add a fake attribute to each |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screws up the scrapper here using a spider trap. Should screw up some other curl based scrappers.