Resolve no-substitution parsing error #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (e.g., COL201505080)
getRetrosheet() fails to parse the downloaded data correctly for games where there are no substitutions. This is relatively rare in recent games (it requires opposing pitchers to both pitch full games), but is common in older games. A reproducible example is: retrosheet::getRetrosheet(type = "play", year = 2015, team = "COL", stringsAsFactors = FALSE) Specifically, this fails on index 12, gameID "COL201505080". https://www.baseball-reference.com/boxes/COL/COL201505080.shtml By checking if there are any substitutions before trying to name the columns, we avoid the problem and return NULL for the .$sub list in games where
…s represented as an empty column instead of NULL. Merge branch 'master' of https://github.com/colindouglas/retrosheet # Conflicts: # R/getRetrosheet.R
…se of some problems with RCurl and TLS
…instead of matrices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRetrosheet() fails to parse the downloaded data correctly for games where there are no substitutions. This is relatively rare in recent games (it requires opposing pitchers to both pitch full games), but is common in older games.
A reproducible example is:
retrosheet::getRetrosheet(type = "play", year = 2015, team = "COL", stringsAsFactors = FALSE)
Specifically, this fails on index 12, gameID "COL201505080".
https://www.baseball-reference.com/boxes/COL/COL201505080.shtml
By checking if there are any substitutions before trying to name the columns, we avoid the problem and return NULL for the .$sub list in games where there were no subs.