-
Notifications
You must be signed in to change notification settings - Fork 2.1k
/
bestPractices.js
33 lines (28 loc) · 1.04 KB
/
bestPractices.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
/*jshint expr:true*/
/*globals describe:true, it:true, expect:true, beforeEach:true */
if (typeof define !== 'function') { var define = require('amdefine')(module); }
if (typeof expect !== 'function') { var expect = require('expect.js'); }
define([
'app/bestPractices'
], function(answers) {
describe('best practices', function(){
it('you should avoid global variables', function() {
answers.globals();
expect(window.myObject).not.to.be.ok;
});
it('you should declare functions safely', function() {
var val = answers.functions(true);
expect(val).to.eql('a');
});
it('you should use parseInt correctly', function() {
expect(answers.parseInt('12')).to.eql(12);
expect(answers.parseInt('12px')).to.eql(12);
expect(answers.parseInt('0x12')).to.eql(0);
});
it('you should understand strict comparison', function() {
expect(answers.identity(1, '1')).to.eql(false);
expect(answers.identity(1, 1)).to.eql(true);
expect(answers.identity(0, false)).to.eql(false);
});
});
});