-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional tests for numbers-related skills #52
Comments
@rmurphey is this still a valid issue? I see that there are number tests that deal both with decimal accuracy and binary operations. What more had you envisioned when writing this issue? |
I. L nun e.g. B On Sat, May 9, 2015 at 8:11 AM, Jake Roufa notifications@github.com wrote: — |
hey @notno! could you... clarify? (trying to discern if this is spam, but your profile looks legit so maybe this is a butt-comment or an encoding issue?) |
@jacobroufa I'm not sure what I meant by this 2.5 years ago :) If it seems resolved, it's probably resolved. |
👍 closing per @rmurphey's comment |
I understood @rmurphey 's comment to be an 'if we feel this is done, then it is done,' rather than an 'okay this is done.' Although we might not know the specifics of the original intention of the post, the post does list three specific types of skills to test:
looking at the answers, we test for one here and here, and two here. What's absent is the third thing on the list, so if we think that it's important to test that, then we might want to reopen this. tho' to be honest I can't think of a solid way to test a random number generator :P |
word @jmeas, i'm gonna keep this closed and open a new issue just for the randomness. it's hard to test random number generation, but not impossible? i figure we can have that a convo in another thread |
The text was updated successfully, but these errors were encountered: