Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for numbers-related skills #52

Closed
rmurphey opened this issue Sep 16, 2012 · 7 comments
Closed

Additional tests for numbers-related skills #52

rmurphey opened this issue Sep 16, 2012 · 7 comments

Comments

@rmurphey
Copy link
Owner

  • dealing with inaccuracies re decimals
  • binary operations
  • "random" number between two numbers
@jamesplease jamesplease changed the title Tests for numbers-related skills Additional tests for numbers-related skills Apr 13, 2015
@jacobroufa
Copy link

@rmurphey is this still a valid issue? I see that there are number tests that deal both with decimal accuracy and binary operations. What more had you envisioned when writing this issue?

@notno
Copy link

notno commented May 9, 2015

I. L nun e.g. B
/
M.p.h. E e. /-. ,--m

On Sat, May 9, 2015 at 8:11 AM, Jake Roufa notifications@github.com wrote:
@rmurphey [https://github.com/rmurphey] is this still a valid issue? I see that there are number tests that deal both
with decimal accuracy and binary operations. What more had you envisioned when
writing this issue?


Reply to this email directly or view it on GitHub
[https://github.com//issues/52#issuecomment-100503744] .[https://github.com/notifications/beacon/ADANgGoqBjxtLXzpoAu72iVKTHvMoYRVks5oHhslgaJpZM4AJ6ml.gif]

@ashleygwilliams
Copy link
Collaborator

hey @notno! could you... clarify? (trying to discern if this is spam, but your profile looks legit so maybe this is a butt-comment or an encoding issue?)

@rmurphey
Copy link
Owner Author

@jacobroufa I'm not sure what I meant by this 2.5 years ago :) If it seems resolved, it's probably resolved.

@ashleygwilliams
Copy link
Collaborator

👍 closing per @rmurphey's comment

@jamesplease
Copy link
Collaborator

I understood @rmurphey 's comment to be an 'if we feel this is done, then it is done,' rather than an 'okay this is done.'

Although we might not know the specifics of the original intention of the post, the post does list three specific types of skills to test:

  1. bitwise operators
  2. floating point arithmetic
  3. pseudo-randomness

looking at the answers, we test for one here and here, and two here. What's absent is the third thing on the list, so if we think that it's important to test that, then we might want to reopen this.

tho' to be honest I can't think of a solid way to test a random number generator :P

@ashleygwilliams
Copy link
Collaborator

word @jmeas, i'm gonna keep this closed and open a new issue just for the randomness. it's hard to test random number generation, but not impossible? i figure we can have that a convo in another thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants