Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests work in browser and node #97

Closed
ashleygwilliams opened this issue Apr 13, 2015 · 5 comments
Closed

Ensure tests work in browser and node #97

ashleygwilliams opened this issue Apr 13, 2015 · 5 comments
Assignees
Labels

Comments

@ashleygwilliams
Copy link
Collaborator

npm test does not currently work. The assessment tests should be able to be run both in the browser, and from the command line with the npm test command.

@kadamwhite
Copy link
Contributor

Additionally, path.existsSync was deprecated and removed in Node 0.12 and IO. The testing harness should be upgraded to be able to be used in these versions.

@ashleygwilliams ashleygwilliams self-assigned this Apr 15, 2015
@ashleygwilliams
Copy link
Collaborator Author

npm test throws this error in both 0.12.2 and iojs-1.7.1

Now using node v0.12.2
(jessie)ag_dubs@localhost:~/js-assessment$ npm test

> js-assessment@0.1.0 test /home/ag_dubs/js-assessment
> ./node_modules/mocha/bin/mocha -R spec tests/runner.js

child_process: customFds option is deprecated, use stdio instead.
/home/ag_dubs/js-assessment/node_modules/requirejs/bin/r.js:2267
        if (path.existsSync(url)) {
                 ^
TypeError: undefined is not a function

@ashleygwilliams
Copy link
Collaborator Author

gonna work on updating the require dependency and see how it goes. currently using 1.0.x, latest release is 2.1.17

@jacobroufa
Copy link

This should be fixed with #112. 👍

@ashleygwilliams
Copy link
Collaborator Author

solved with #112, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants