Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't browse at remove after the package update #79

Closed
achempion opened this issue May 27, 2021 · 2 comments
Closed

Can't browse at remove after the package update #79

achempion opened this issue May 27, 2021 · 2 comments

Comments

@achempion
Copy link

Right now when I call browse-at-remote function I get the message

browse-at-remote--get-remote-type: Sorry, not sure what to do with domain ‘github.com’ (consider adding it to ‘browse-at-remote-remote-type-domains’)

but I already have GitHub domain in a variable

browse-at-remote-remote-type-domains is a variable defined in ‘browse-at-remote.el’.
Its value is shown below.

  You can customize this variable.

Documentation:
Alist of domain names to remote types.

Value:
(("bitbucket.org" . "bitbucket")
 ("github.com" . "github")
 ("gitlab.com" . "gitlab")
 ("git.savannah.gnu.org" . "gnu")
 ("gist.github.com" . "gist")
 ("git.sr.ht" . "sourcehut")
 ("vs-ssh.visualstudio.com" . "ado")
 ("pagure.io" . "pagure")
 ("src.fedoraproject.org" . "pagure"))

[back]

My version is 20210527.451 and I didn't make any modifications related to this package.

@rmuslimov
Copy link
Owner

This was my bad with merging and pushing untested changes, fixes this in latest commit. Please let me know if issue is still there. cc @jackrosenthal

@jackrosenthal
Copy link
Contributor

Thanks. We should add in a bit more test coverage here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants