Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Complete Maintainers file #1

Closed
kelset opened this issue Mar 20, 2019 · 14 comments
Closed

TODO: Complete Maintainers file #1

kelset opened this issue Mar 20, 2019 · 14 comments
Labels
chore Something that needs to be done in this repository

Comments

@kelset
Copy link
Contributor

kelset commented Mar 20, 2019

Let's complete the table with the full list of repositories in the org and the maintainers and status.

@kelset kelset added the chore Something that needs to be done in this repository label Mar 20, 2019
@kelset
Copy link
Contributor Author

kelset commented Mar 20, 2019

Hey everyone

@thymikee, @grabbou, @Esemesek, @sibelius, @emilioicai, @jamonholmgren, @Titozzz, @krizzu, @dmtrKovalenko, @radex, @zoontek, @rborn, @christopherdro, @salah-ghanim, @cobarx, @michalchudziak, @Trancever, @msand, @satya164, @jgcmarins, @ferrannp, @bartolkaruza, @gre, @kmagiera, @kmagiera, @DanielZlotin, @Ansalibrahim, @Swaagie, @dabit3, @melihberberolu, @matt-oakes, @pvinis, @ivanzotov, @vonovak, @FonDorn, @Kureev, @hannigand, @mmazzarolo, @rewieer, @janicduplessis, @charpeni, @brentvatne, @cesargdm, @jimmylee, @FruitieX, @alihamza, @harisbaig100, @rafaellincoln

By looking at the commit history of each repository in the org, it looks like you are maintainers for at least one of them - so I've added you to https://github.com/react-native-community/meta/blob/master/MAINTAINERS.md (if someone is missing please submit a PR 🤗)

In the scenario in which you are not super aware of what's happening, why I @-ed you here: basically, we are trying to give more structure to the whole RNCommunity as it is now the official community for react native.

You can see that there is a guidelines folder with some files, and through PRs we'll fill the stubs there so to give all of you a change to review and comment on those "suggestions".

I hope we will be able to get to a point where all the repos in this org are all aligned on some defaults so that we can increase the confidence of the larger developer community using React Native and the code contained (as also said in the README).

For reference, here is where the conversation started/happened:

If you feel that noone of this lines up with how you want to maintain your library please comment it here, we can see how we can change things up for you or we can explore moving the repo out of the org - but hopefully we'll find a way to collaborate :)

Also, if you are not on the React Native Core Contributors Discord please DM me over on twitter with the email you want to be invited with.

@kelset
Copy link
Contributor Author

kelset commented Mar 20, 2019

@kelset
Copy link
Contributor Author

kelset commented Mar 29, 2019

Ok 9 days ago I pinged all of you but more than a few actually never replied.

I'll wait a week then I'll start considering kicking the repos out of the community org.

@vonovak
Copy link
Contributor

vonovak commented Mar 29, 2019

If you feel that none of this lines up with how you want to maintain your library please comment it here, we can see how we can change things up for you or we can explore moving the repo out of the org - but hopefully we'll find a way to collaborate :)

I think most people (myself included) never replied because they agree with what was outlined. 👍 I don't necessarily see a reason to move repos out of the org unless no one wants to maintain them 😢

@mmazzarolo
Copy link

Same here.
I'm probably missing something @kelset, were you waiting for some active feedbacks/changes to the repos? 🤔

@kelset
Copy link
Contributor Author

kelset commented Mar 29, 2019

No no it was mostly a ping for the people who didn't reach out to me yet in any way 🤗 (as you can see there are like 40 people that I @-ed and like 20 still haven't reached out)

re: @vonovak

I don't necessarily see a reason to move repos out of the org unless no one wants to maintain them 😢

I'd really prefer to not touch repos for which I don't have a communication line with the maintainers, hence why moving them out instead of starting to ex. change the readme and archive the repo if it's been inactive for 6+ months.
And a repo being unmaintained is not necessarely a reason to move it out - absolutely - example: #10

@dabit3
Copy link

dabit3 commented Mar 29, 2019

Hey @kelset , what do we need to do?

@kelset
Copy link
Contributor Author

kelset commented Mar 29, 2019

  1. feedback on the ongoing discussions in the other issues if you have time

Also, if you are not on the React Native Core Contributors Discord please DM me over on twitter with the email you want to be invited with.

  1. ensure that MAINTAINERS.md is correct -> https://github.com/react-native-community/meta/blob/master/MAINTAINERS.md (maybe the person @-ed is not really a maintainer/not anymore)

@sibelius
Copy link
Contributor

we can remove cameraview, as react-native-camera does not use it anymore, it has a copy inside the repo

we moved examples back to react-native-camera, so rncamera-example can be removed

@rafaellincoln
Copy link

I think Discord is a better place to keep up with the work of the maintainers. Has group already been exists?

@rborn
Copy link
Collaborator

rborn commented Mar 29, 2019

cc: @alvelig

@kelset
Copy link
Contributor Author

kelset commented Apr 1, 2019

@rafaellincoln, as I mentioned above, yes there is a Discord already - can you please DM me so that I can send you the invite link?

@kelset
Copy link
Contributor Author

kelset commented May 27, 2019

Quick update on this:

given that it's not easy to maintain a .md file with all the repos & the maintainers, following some conversation happened here: #23 and on the Discord, we will be actually moving towards instead using the CodeOwners file in each of the repo.

It's going to be long effort but it will be more scalable in the long term.

I'd like to invite each maintainer to add that file with all the maintainers to the repo their are maintaining, I'll try to help over the next few weeks so that then we can modify the script Matt created to scrape it.

jgcmarins added a commit to react-native-share/react-native-share that referenced this issue May 27, 2019
jamonholmgren added a commit to react-native-webview/react-native-webview that referenced this issue May 29, 2019
@kelset kelset mentioned this issue May 29, 2019
Titozzz pushed a commit to react-native-webview/react-native-webview that referenced this issue Jun 2, 2019
mikehardy added a commit to mikehardy/react-native-device-info that referenced this issue Jun 3, 2019
mikehardy added a commit to react-native-device-info/react-native-device-info that referenced this issue Jun 3, 2019
@kelset
Copy link
Contributor Author

kelset commented Jun 27, 2019

Ok, I've updated the Maintainers - now it's complete AFAIK.

@kelset kelset closed this as completed Jun 27, 2019
phuongwd pushed a commit to phuongwd/react-native-webview that referenced this issue Apr 29, 2020
mobiledev7 added a commit to mobiledev7/react-native-share that referenced this issue Dec 12, 2022
WictorWilnd pushed a commit to WictorWilnd/react-native-device-info that referenced this issue Feb 27, 2023
noproblem23 added a commit to noproblem23/react-native-webview that referenced this issue Apr 18, 2023
wdavis122 added a commit to wdavis122/react-native-device-info that referenced this issue Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that needs to be done in this repository
Projects
None yet
Development

No branches or pull requests

7 participants