Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native-permissions #50

Merged
merged 1 commit into from Jul 16, 2019
Merged

Add react-native-permissions #50

merged 1 commit into from Jul 16, 2019

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Jul 11, 2019

Summary

Add react-native-permissions to the organisation.
The next major version will come (very) soon.

@zoontek zoontek requested a review from kelset July 11, 2019 08:13
@MateusAndrade
Copy link
Contributor

@kelset anyone that is member of react-native-community can merge this PR's without any problem?

@kelset
Copy link
Contributor

kelset commented Jul 15, 2019

I think so, because of #40 :D
Probably I should add a codeowners that adds me as required reviwer but this repo is a bit of an edge case so I'm not sure it should be the way to go.

But yeah I'll take care of this today, sorry but last week was ChainReact and I was swamped with things to do.


Also, the repo is still under his owner -> https://github.com/yonahforst/react-native-permissions so until that's transferred to me and then to the RNComm we shouldn't merge this yet.

@yonahforst
Copy link

hey @kelset, I just transferred the repo to you :) thanks for keeping this alive, you guys!! 💝

@kelset kelset merged commit bd87340 into rnc-archive:master Jul 16, 2019
@kelset
Copy link
Contributor

kelset commented Jul 16, 2019

No, thank you all for taking care of this proj! Now the repo is live https://github.com/react-native-community/react-native-permissions 🎉

@zoontek
Copy link
Contributor Author

zoontek commented Jul 16, 2019

Now let's ship this new version 😃

@zoontek zoontek deleted the add-react-native-permissions branch July 17, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants