Fix loop fade when pitch is higher than origin #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise m_xgain1 decreases too slowly and suddenly go from some positive value to 0 producing an audible click.
|
This is related to the messages at the end of https://sourceforge.net/p/samplv1/tickets/13/ BTW, let me know if you prefer another place to submit patches (I didn't find an easy way to send them via sourceforge, thus why I'm using github). |
|
GH is always a good place to PR's cheers && thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise m_xgain1 decreases too slowly and suddenly go from some
positive value to 0 producing an audible click.