Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use slack's internal markdown converter #65

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

nobe4
Copy link
Contributor

@nobe4 nobe4 commented Apr 10, 2024

This is a companion PR that goes with
rneatherway/slack#4 to showcase what changes will look like in the gh-slack client.

It keeps the code as untouched as possible, and cleans the obsolete functions/types.

The code currently uses the latest commit on rneatherway/slack#4 and will need to be updated accordingly if/when that PR is merged.

Current version fetched with:

go get github.com/rneatherway/slack@d41e05cbe802da709eba14bffd8d6bf3716aa0d9

This is a companion PR that goes with
rneatherway/slack#4 to showcase what changes
will look like in the gh-slack client.

It keeps the code as untouched as possible, and cleans the obsolete
functions/types.
@rneatherway
Copy link
Owner

These changes look good to me 😄

Feel free to merge when ready.

@nobe4
Copy link
Contributor Author

nobe4 commented Apr 12, 2024

Thanks @rneatherway! It seems that by updating to a specific commit, I've polluted the go.mod file. Maybe we can create a release of slack? That might fix this?

Any thoughts?

@rneatherway
Copy link
Owner

Thanks @rneatherway! It seems that by updating to a specific commit, I've polluted the go.mod file. Maybe we can create a release of slack? That might fix this?

What do you mean when you say that you've polluted it? I don't have any trouble running the tests locally on this PR.

@nobe4
Copy link
Contributor Author

nobe4 commented Apr 13, 2024

I meant to say that the go.mod got a bunch of duplicate lines from installing the various commits by hands.

I don't really know if it's problematic but it looks unnecessary 🧐

@rneatherway
Copy link
Owner

Ah! I see what you mean now. Try running go mod tidy - that should clear it up 😄

@nobe4
Copy link
Contributor Author

nobe4 commented Apr 14, 2024

Indeed! Thanks 🙏

@rneatherway rneatherway merged commit 8b1c7f7 into rneatherway:main Apr 15, 2024
2 checks passed
@nobe4 nobe4 deleted the markdown branch April 15, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants