This repository has been archived by the owner on May 4, 2023. It is now read-only.
running couchdb-lucene using .war file #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting when running via Tomcat. Extracted configuration handling to Config class, used by Main and LuceneServlet's no-arg constructor.
…fy war file build using mvn war:war. Assembly descriptor still puts those resources files to conf dir in -dist.zip .
|
Forgot to add, the .war file is handy for running couchdb-lucene on a servlet container like Tomcat. |
|
Hi Cliffano, I like the idea of running (optionally) from a WAR file. The commits contain a considerable about of reformatting / white space changes, which makes it hard to see the substantive changes, I'd be grateful if you could fix those and send an updated pull request. |
|
Whoops, didn't realise I mangled the indentation. It's all good now. I think my last commit is automatically included in this pull request https://github.com/rnewson/couchdb-lucene/pull/118/files . |
rnewson
pushed a commit
that referenced
this pull request
May 26, 2011
running couchdb-lucene using .war file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couchdb-lucene-.war can now be generated using mvn war:war.
coucdbb-lucene--dist.zip stays the same, built using the assembly descriptor.
Extracted config handling to com.github.rnewson.couchdb.lucene.Config, now used by both com.github.rnewson.couchdb.lucene.Main and com.github.rnewson.couchdb.lucene.LuceneServlet no-argument constructor. LuceneServlet no-arg constructor is useful for web.xml config.