running couchdb-lucene using .war file #118

Merged
merged 4 commits into from May 26, 2011

Conversation

Projects
None yet
2 participants
@cliffano
Contributor

cliffano commented May 25, 2011

couchdb-lucene-.war can now be generated using mvn war:war.
coucdbb-lucene--dist.zip stays the same, built using the assembly descriptor.

Extracted config handling to com.github.rnewson.couchdb.lucene.Config, now used by both com.github.rnewson.couchdb.lucene.Main and com.github.rnewson.couchdb.lucene.LuceneServlet no-argument constructor. LuceneServlet no-arg constructor is useful for web.xml config.

cliffano added some commits May 19, 2011

Added no-argument constructor to LuceneServlet, handy for web.xml set…
…ting when running via Tomcat. Extracted configuration handling to Config class, used by Main and LuceneServlet's no-arg constructor.
Added web.xml and renamed main/conf to main/resources, both to simpli…
…fy war file build using mvn war:war. Assembly descriptor still puts those resources files to conf dir in -dist.zip .
@cliffano

This comment has been minimized.

Show comment Hide comment
@cliffano

cliffano May 25, 2011

Contributor

Forgot to add, the .war file is handy for running couchdb-lucene on a servlet container like Tomcat.

Contributor

cliffano commented May 25, 2011

Forgot to add, the .war file is handy for running couchdb-lucene on a servlet container like Tomcat.

@cliffano cliffano closed this May 25, 2011

@cliffano cliffano reopened this May 25, 2011

@rnewson

This comment has been minimized.

Show comment Hide comment
@rnewson

rnewson May 26, 2011

Owner

Hi Cliffano,

I like the idea of running (optionally) from a WAR file. The commits contain a considerable about of reformatting / white space changes, which makes it hard to see the substantive changes, I'd be grateful if you could fix those and send an updated pull request.

Owner

rnewson commented May 26, 2011

Hi Cliffano,

I like the idea of running (optionally) from a WAR file. The commits contain a considerable about of reformatting / white space changes, which makes it hard to see the substantive changes, I'd be grateful if you could fix those and send an updated pull request.

@cliffano

This comment has been minimized.

Show comment Hide comment
@cliffano

cliffano May 26, 2011

Contributor

Whoops, didn't realise I mangled the indentation. It's all good now.

I think my last commit is automatically included in this pull request https://github.com/rnewson/couchdb-lucene/pull/118/files .

Contributor

cliffano commented May 26, 2011

Whoops, didn't realise I mangled the indentation. It's all good now.

I think my last commit is automatically included in this pull request https://github.com/rnewson/couchdb-lucene/pull/118/files .

rnewson pushed a commit that referenced this pull request May 26, 2011

Robert Newson
Merge pull request #118 from cliffano/master
running couchdb-lucene using .war file

@rnewson rnewson merged commit 0081272 into rnewson:master May 26, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment