This repository has been archived by the owner on May 4, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that you have previously mentioned that you would prefer to implement this sort of thing using a UserRealm, but then one would have to maintain a session in Jetty just for the sake of CouchDB.
One great benefit of going the pass-through way is that it makes it much easier to implement secure search when dealing with multiple separate CouchApps (as I pass both the CouchDB auth-session cookie as well as the authentication header if present).
Yet another benefit is that one does not have to have to store a couchdb user's username and password in clear-text in couchdb-lucene.ini.
Note that this commit will not break the current behaviour. If credentials are specified in couchdb-lucene.ini, these will still be used, so any user can access what the credentials give access to.