Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] make it modal compatible #1

Open
AlejandroGutierrezB opened this issue May 4, 2023 · 3 comments
Open

[Request] make it modal compatible #1

AlejandroGutierrezB opened this issue May 4, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@AlejandroGutierrezB
Copy link

Hey, first of all really nice job on this package.

I encountered it after I saw your comment on react-native-toast-message, and wheres this solves that issue, your package is not showing on the modal view.

You can render a toast on a modal view, but if you do so the queuing loses track and you can't render the global one.

Maybe I am missing something and it can be done, if so could you provide an example.

If not, I would say that is a very important feature to support.

Thanks again and have a nice day!

@enestatli
Copy link
Member

enestatli commented May 5, 2023

Hey, first of all really nice job on this package.

I encountered it after I saw your comment on react-native-toast-message, and wheres this solves that issue, your package is not showing on the modal view.

You can render a toast on a modal view, but if you do so the queuing loses track and you can't render the global one.

Maybe I am missing something and it can be done, if so could you provide an example.

If not, I would say that is a very important feature to support.

Thanks again and have a nice day!

Hello, thank you.

We are working on this recently, I hope we can make it.

Right now you can wrap Toaster with FullWindowOverlay imported from react-native-screens

import { FullWindowOverlay } from 'react-native-screens';
import Toastable from 'react-native-toastable';

<FullWindowOverlay>
   <Toastable  />
</FullWindowOverlay>

Note that FullWindowOverlay works only for iOS

@enestatli enestatli added the enhancement New feature or request label May 19, 2023
@yigithanyucedag yigithanyucedag added the help wanted Extra attention is needed label Aug 6, 2023
@Aleksandern
Copy link

@enestatli
Hello.
Any news about the modal issue?

@mozzius
Copy link

mozzius commented Nov 24, 2023

Hello, thank you.

We are working on this recently, I hope we can make it.

Right now you can wrap Toaster with FullWindowOverlay imported from react-native-screens

import { FullWindowOverlay } from 'react-native-screens';
import Toastable from 'react-native-toastable';

<FullWindowOverlay>
   <Toastable  />
</FullWindowOverlay>

Note that FullWindowOverlay works only for iOS

This is not an acceptable solution - it completely breaks VoiceOver accessibility. Would love to see a better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants