Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters for binding classes using parentheses #3

Closed
wants to merge 2 commits into from

Conversation

drosen0
Copy link
Contributor

@drosen0 drosen0 commented Sep 6, 2012

Here's an implementation of #1 except using parentheses and commas, like:

<div data-class="renderSection(overview)"></div>
<!-- ko class: render(section,overview) -->
<!-- /ko -->

No spaces are allowed, except between classes. I believe this limitation is fine, since the intent is only to pass a string or two as an identifier. I already started using it and I like the new syntax better than the : syntax.

@rniemeyer
Copy link
Owner

Landed the implementation in #7 as opposed to this one.

@rniemeyer rniemeyer closed this Sep 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants