Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to use of domData breaks 'targetIndex' #3

Closed
sagacity opened this issue Feb 21, 2012 · 1 comment
Closed

Change to use of domData breaks 'targetIndex' #3

sagacity opened this issue Feb 21, 2012 · 1 comment

Comments

@sagacity
Copy link

Now that the plugin uses domData it will always insert a dropped element at the end of the list.

This can be reproduced by looking at your original example:
http://jsfiddle.net/UdXr4/

I have updated it to point to the latest version of your plugin, where it is showing this incorrect behavior:
http://jsfiddle.net/UdXr4/9/
rniemeyer added a commit that referenced this issue Feb 21, 2012
@rniemeyer
Fix targetIndex issue (childNodes included text nodes) for Issue #3.
799dd17
@rniemeyer
Copy link
Owner

childNodes contains text nodes, which was throwing the index off. Switched back to the previous code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sagacity @rniemeyer