Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build):allow running example on M1 #1703

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

naftalibeder
Copy link
Collaborator

@naftalibeder naftalibeder commented Jan 13, 2022

Description

Changes build configurations to allow the example project to build on M1 Macs.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • (n/a) I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • (n/a) I updated the typings files (index.d.ts)
  • (n/a) I added/ updated a sample (/example)

@naftalibeder
Copy link
Collaborator Author

@mfazekas @ferdicus My apologies again about the overextended changes in https://github.com/react-native-mapbox-gl/maps/pull/1643. This new PR has just the changes required to make the example run on M1 Macs.

@bjarn @doylemark Would you be interested in testing to see if this works?

@bjarn
Copy link

bjarn commented Jan 14, 2022

Though I still had to exclude arm64 for Simulator SDKs - but that's an upstream issue with Mapbox - it works! Custom map styles also don't seem to show up. Will have to dive into that.

Building works perfectly fine now tho!

Update: custom map styles work, but load a bit slower than normal

@mfazekas mfazekas merged commit 1e95594 into rnmapbox:master Jan 14, 2022
@naftalibeder
Copy link
Collaborator Author

@bjarn Glad to hear it works! Not sure about the slowness issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants