Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved web Camera #3473

Merged
merged 1 commit into from
May 13, 2024
Merged

Improved web Camera #3473

merged 1 commit into from
May 13, 2024

Conversation

VolkerLieber
Copy link
Contributor

@VolkerLieber VolkerLieber commented May 5, 2024

Description

Implemented all methods of CameraRef except SetCamera and implemented zoom CameraProps

Checklist

  • I've read CONTRIBUTING.md
  • I have tested the new feature

Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!
Pls fix lint errors

Implemented all methods of CameraRef except SetCamera and implemented zoom CameraProps
@VolkerLieber
Copy link
Contributor Author

Done, although the lint errors were like: animationDuration: number = 0 should be animationDuration = 0, which I'm personally not a big fan of because it potentially removes the instruction about the specific type for future developers.

@mfazekas
Copy link
Contributor

Done, although the lint errors were like: animationDuration: number = 0 should be animationDuration = 0, which I'm personally not a big fan of because it potentially removes the instruction about the specific type for future developers.

Thanks, yeah I hear you. I'm not 100% about this lint rule either. I think it's not something we use directly, but we're inheriting it from rn preset, in that case I'd vote for keeping it just for consistency with rn projects, otherwise I'm fine with removing that lint rule.

@mfazekas mfazekas merged commit 7f99408 into rnmapbox:main May 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants