-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider to use shorter armor lines #1099
Comments
@kaie @ronaldtse It can be easily changed, the only problem I see is propagating the line length parameter through the whole API. |
Just FYI, I tested and can confirm that changing the hardcoded value in the line mentioned above is sufficient to change the line length. |
@ni4 Did you mean to configure it via |
@rrrooommmaaa No, Also |
Not sure if you like this indirection, but here's another potential approach: rnp_output_armor_set_line_length(rnp_output_t out_armor, size_t len); You could define that calling rnp_output_armor_set_line_length is allowed, only, if parameter out_armor has been obtained from rnp_output_to_armor. |
And maybe allow it to be set for the output object given to rnp_enarmor |
@kaie Agree, However not sure whether this possible for rnp_enarmor, since there output may be of any type, and all work is done in one pass. Probably, this should be better replaced with combination of |
When exporting armored blocks, e.g. for public keys, RNP uses a fixed line length of 76 chars. I believe this is set in the following line:
When attaching these in email, Thunderbird wraps it at position 73.
(Armored blocks produced by GnuPG wrap at position 64, and didn't cause Enigmail to wrap.)
It's not a big deal, it simply looks slightly ugly when looking at the message source (with alternating lines of 73 and 3 characters).
Not sure if I should ask you to change it to 64, too, or make it configurable. What do you think?
Low priority, because from the functional perspective its working fine.
The text was updated successfully, but these errors were encountered: