Justus/make tests more robust #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2020 11:02
Let the shell locate 'cp'. This is more robust in environments such as Guix or Nix that do not provide /bin/cp.
GnuPG will try to read its state even for operations that do not require it, e.g. listing packets. If the state directory does not exist, GnuPG will try to create it. If this fails, GnuPG errors out. In some build environments, $HOME may not exist or may not be writable (e.g. in Guix and Nix, $HOME does not exist). This leads to a spurious test failures when GnuPG is invoked to inspect packets. Fix this by using the current directory as GnuPG state directory.
Previously, a failing test leaving RNP or GnuPG state directories behind would cause all tests following it to fail. Improve this by removing the directories first should they exist.
ronaldtse
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.