Refactor pgp_packet_body_t to be more C++. #1350
Conversation
ni4
force-pushed
the
ni4-refactor-pgp_packet_body_t
branch
from
e7155fd
to
ae355b2
Compare
ni4
requested review from
rrrooommmaaa,
antonsviridenko,
dewyatt and
ronaldtse
|
There are some CI timeout issues, but those seems to be caused by GHA, investigating them. |
| /** @brief write packet header, length and body to the dst | ||
| * @param dst destination to write to. | ||
| **/ | ||
| void write(pgp_dest_t &dst, bool hdr = true) noexcept; |
There was a problem hiding this comment.
hdr parameter is not documented
src/librepgp/stream-packet.h
Outdated
| * or mpi is ill-formed) | ||
| **/ | ||
| bool get(pgp_mpi_t &val) noexcept; | ||
| /** @brief append chunk of the data to the packet body |
There was a problem hiding this comment.
some phantom brief here
ni4
force-pushed
the
ni4-refactor-pgp_packet_body_t
branch
from
ae355b2
to
fabf966
Compare
|
It seems that the macOS test is never completing. I've restarted it a few hours ago...? |
Yeah, I also restarted it few times/tried on my fork. Looks like something is wrong with macOS runners, but still let's investigate it first. |
|
Looks like macOS 11 GHA works much faster - it finished in 20 minutes here: #1353 |
ni4
force-pushed
the
ni4-refactor-pgp_packet_body_t
branch
from
fabf966
to
85c11e8
Compare
|
Merging as we have two approvals and passing CI. |
This PR refactors pgp_packet_body_t and packet parsing/writing to be more C++, having cleaner code and destructor-based memory freeing.
It will be updated with the code borrowed from PR #1349 via new PRs once merged.