Disable shared libs configuraion on MSVC

rnpgp · Jun 17, 2023 · 69c6442 · 69c6442
1 parent 53d824f
commit 69c6442
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -53,6 +53,10 @@ jobs:
         include:
           - { os: ubuntu-20.04, env: { CC: clang, CXX: clang++ }, shared: on }
           - { os: ubuntu-20.04, env: { CC: clang, CXX: clang++ }, shared: off }
+        # Builds sexp dll with MSVC is not supported
+        exclude:
+          - { os: windows-2019, env: { }, shared: on }
+
     env: ${{ matrix.env }}
     steps:
       - name: Checkout

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -48,13 +48,15 @@ include(CheckCXXSourceCompiles)
 
 if (BUILD_SHARED_LIBS)
     set(TYPE "SHARED")
-    if (WIN32)
-        set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS, TRUE)
-    endif(WIN32)
 else (BUILD_SHARED_LIBS)
     set(TYPE "STATIC")
 endif (BUILD_SHARED_LIBS)
 
+if (BUILD_SHARED_LIBS AND MSVC)
+    message(FATAL_ERROR "Building sexp shared library with MSVC is not supported")
+endif(BUILD_SHARED_LIBS AND MSVC)
+
+
 message(STATUS "Building ${TYPE} library")
 
 if (WITH_SANITIZERS)

diff --git a/include/sexp/ext-key-format.h b/include/sexp/ext-key-format.h
@@ -30,6 +30,7 @@
 #pragma once
 
 #include <map>
+
 #include "sexp.h"
 
 namespace ext_key_format {