Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit allowed nesting layers in print_xxx; #36

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Jun 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1dd6f68) 99.70% compared to head (9620c41) 99.70%.

❗ Current head 9620c41 differs from pull request most recent head 365fdc9. Consider uploading reports for the commit 365fdc9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files           9       10    +1     
  Lines         668      689   +21     
=======================================
+ Hits          666      687   +21     
  Misses          2        2           
Impacted Files Coverage Δ
include/sexp/sexp.h 100.00% <100.00%> (ø)
src/sexp-depth-manager.cpp 100.00% <100.00%> (ø)
src/sexp-input.cpp 100.00% <100.00%> (ø)
src/sexp-object.cpp 98.55% <100.00%> (ø)
src/sexp-output.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxirmx maxirmx linked an issue Jun 20, 2023 that may be closed by this pull request
@maxirmx maxirmx changed the title Limit possible nesting layers in print_xxx; Limit allowed nesting layers in print_xxx; Jun 20, 2023
@maxirmx maxirmx marked this pull request as ready for review June 20, 2023 11:59
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxirmx ! Please feel free to merge when ready!

@maxirmx maxirmx merged commit 55dd146 into main Jun 20, 2023
55 checks passed
@maxirmx maxirmx deleted the maxirmx-issue-27 branch June 20, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit possible nesting layers in scan_object()
2 participants