Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed the project and project artifacts to sexpp; added a filter for symbol visibility #48

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Renamed the project and project artifacts to sexpp; added a filter for symbol visibility #48

merged 4 commits into from
Jun 26, 2023

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Jun 24, 2023

No description provided.

@maxirmx maxirmx linked an issue Jun 24, 2023 that may be closed by this pull request
name conflict libsexp (rnpgp/sexp and mjsottile/sfsexp) #45
Closed
@maxirmx maxirmx force-pushed the maxirmx-rename branch 6 times, most recently from aca369a to 555f0e4 Compare June 24, 2023 20:17
@codecov
Copy link

codecov bot commented Jun 24, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (803744e) 99.70% compared to head (358defd) 99.70%.

❗ Current head 358defd differs from pull request most recent head d100d6c. Consider uploading reports for the commit d100d6c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          10       10           
  Lines         689      689           
=======================================
  Hits          687      687           
  Misses          2        2
Impacted Files Coverage Δ
include/sexpp/ext-key-format.h 100.00% <ø> (ø)
include/sexpp/sexp.h 100.00% <ø> (ø)
src/ext-key-format.cpp 100.00% <ø> (ø)
src/sexp-depth-manager.cpp 100.00% <ø> (ø)
src/sexp-error.cpp 100.00% <ø> (ø)
src/sexp-input.cpp 100.00% <ø> (ø)
src/sexp-object.cpp 98.55% <ø> (ø)
src/sexp-output.cpp 100.00% <ø> (ø)
src/sexp-simple-string.cpp 98.61% <ø> (ø)
include/sexpp/sexp-error.h 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxirmx maxirmx force-pushed the maxirmx-rename branch 3 times, most recently from 1e4a239 to 59ca040 Compare June 25, 2023 15:37
@maxirmx maxirmx linked an issue Jun 25, 2023 that may be closed by this pull request
Consider symbol visibility for shared library #41
Open
@maxirmx maxirmx changed the title Renamed the project and project artifacts to sexpp Renamed the project and project artifacts to sexpp; filter symbol visibility Jun 25, 2023
@maxirmx maxirmx changed the title Renamed the project and project artifacts to sexpp; filter symbol visibility Renamed the project and project artifacts to sexpp; added a filter for symbol visibility Jun 25, 2023
@maxirmx maxirmx marked this pull request as ready for review June 25, 2023 18:54
@maxirmx maxirmx requested a review from ronaldtse June 25, 2023 19:01
ronaldtse
ronaldtse reviewed Jun 25, 2023
View reviewed changes
.github/workflows/coverity.yml Outdated
MAKEFLAGS: j4
TOKEN: qjcM1CWLcq9PJB3yL0ZXIw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxirmx I believe we don't need the Coverity token when the repository is public. Can you confirm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronaldtse
It does not work without token: https://github.com/rnpgp/sexpp/actions/runs/5375142016/jobs/9751251719
Documentation is somewhat unclear about it but I found an action https://github.com/marketplace/actions/unofficial-coverity-scan and its documentation says that the TOKEN is required

I am using this action now. We may want to move Coverity token to secrets and use ribose e-mail instead of my personal.

@ronaldtse
Copy link
Contributor

Thank you @maxirmx ! Please feel free to merge after answering the remaining question.

@maxirmx maxirmx merged commit e265f63 into main Jun 26, 2023
@maxirmx maxirmx deleted the maxirmx-rename branch June 28, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider symbol visibility for shared library name conflict libsexp (rnpgp/sexp and mjsottile/sfsexp)
2 participants
@maxirmx @ronaldtse