Replaced string<octet_t> with vector<octet_t> to adhere to C++ standard #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 99.70% 99.71%
=======================================
Files 10 10
Lines 689 706 +17
=======================================
+ Hits 687 704 +17
Misses 2 2 ☔ View full report in Codecov by Sentry. |
maxirmx
force-pushed
the
maxirmx-no-octet-strings
branch
4 times, most recently
from
867a0c1
to
2af0368
Compare
maxirmx
changed the title
maxirmx
changed the title
maxirmx
force-pushed
the
maxirmx-no-octet-strings
branch
from
2af0368
to
a5ee882
Compare
maxirmx
force-pushed
the
maxirmx-no-octet-strings
branch
2 times, most recently
from
de3318a
to
532f151
Compare
maxirmx
force-pushed
the
maxirmx-no-octet-strings
branch
from
532f151
to
25bd9d7
Compare
|
@maxirmx please help merge when ready. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51