Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented char_traits for SEXP octet_t #54

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Jun 3, 2024

No description provided.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (92ce195) to head (46744a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   99.70%   99.71%           
=======================================
  Files          10       10           
  Lines         689      692    +3     
=======================================
+ Hits          687      690    +3     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxirmx maxirmx force-pushed the maxirmx-octet_t-traits branch 2 times, most recently from 4727cf2 to 2145552 Compare June 3, 2024 11:09
@maxirmx maxirmx requested review from ni4 and removed request for ni4 June 3, 2024 11:19
@maxirmx maxirmx force-pushed the maxirmx-octet_t-traits branch 5 times, most recently from e3aac15 to 35a13f9 Compare June 6, 2024 12:15
@maxirmx
Copy link
Member Author

maxirmx commented Jun 6, 2024

Another attempt to fix #51 using different approach

Copy link

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could it be checked whether ABI is not changed once this PR is merged?

@maxirmx maxirmx merged commit 758d7bd into main Jun 13, 2024
57 checks passed
@maxirmx maxirmx deleted the maxirmx-octet_t-traits branch June 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants