Wallet Connect #357
Merged
Wallet Connect #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version was not compatible with wallet connect and was showing the error `this.send is not a function`. This behavior is documented in this issue here: web3/web3.js#3790. The reccomendation was to downgrade to 1.2.x but in this case, we are upgrading to it.
- This code gets executed if a provider is present. Therefor hasMetamask is always true. Remove if statement. - Use
- Metamask & Nifty return an integer where as WalletConnect returns a boolean.
- Redux and connections
jessgusclark
force-pushed
the
wallet-connect
branch
from
7c40a91
to
10e7b66
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
javiesses
reviewed
Jan 7, 2021
Comment on lines
+408
to
+409
| "is_wallet_connect_warning": "WalletConnect is a experimental provider and not all RNS manager operations work.", | ||
| "wallet_connect_feature": "This feature does not work with WalletConnect." |
There was a problem hiding this comment.
Do not forget the translations 🙏
javiesses
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Like it, I've tested it from GH pages. Managed to create a domain and then a subdomain.
Had some issues with the subdomain creation, it seems it is not receiving well the event when the tx is confirmed, so it never shows the new subdomain in the list. Then I refresh, disconnect from Wallet Connect and tried again and it worked like a charm
juan-rsk
pushed a commit
to juan-rsk/rns-manager-react
that referenced
this pull request
Apr 6, 2021
* Add wallet-connect package and connect to rLogin init. * Bump web3 version The previous version was not compatible with wallet connect and was showing the error `this.send is not a function`. This behavior is documented in this issue here: web3/web3.js#3790. The reccomendation was to downgrade to 1.2.x but in this case, we are upgrading to it. * Update auth/operations start - This code gets executed if a provider is present. Therefor hasMetamask is always true. Remove if statement. - Use * Transaction listener should return success on true - Metamask & Nifty return an integer where as WalletConnect returns a boolean. * Listen to disconnect event, move disconnect above login. * Fix propTypes error. * Remove console.log, fix lint. * Remove commented out code. * Rename hasMetamask to hasWeb3Provider - Redux and connections * Add isWalletConnect redux prop. * Add messages where wallet connect functionality does not work. * Fix lint issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WalletConnect as a web3Provider to rLogin.
Operations that require more than one transaction are disabled as they don't work with the existing wallets. A warning is showed on the Domain Information screen as well as the two places where operations do not work.
Was tested with rWallet and defiant wallet.
testing:
This can be tested by using this link: https://rnsdomains.github.io/rns-manager-react/
Since this test is to Github pages, you will probably experience 404 errors and broken images. Please navigate using the header.