feat (pagination): Add pagination to message list. #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafin
force-pushed
the
feat/pagination-messages
branch
from
0e3f5b0
to
079943f
Compare
Added client Config 'PageSize' to control defaults.
jafin
force-pushed
the
feat/pagination-messages
branch
from
079943f
to
2474b04
Compare
|
@jafin Sorry for the huge delay in reviewing this. Please can you rebase onto master. |
jafin
force-pushed
the
feat/pagination-messages
branch
from
324ca4c
to
f3f19d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pagination to the message list. Default set to 30 messages per page.
Adds pagination to session list.
Added client Config
PageSizeto control default value for paging.resolves #906
resolves #935 by virtue of paging to limit resultset of the session to less than 8192 rows.
Additional changes