Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Repo paging control #336

Merged
merged 4 commits into from Sep 22, 2017
Merged

Repo paging control #336

merged 4 commits into from Sep 22, 2017

Conversation

rnystrom
Copy link
Member

Mostly a heads-up for @Sherlouk while he's working on projects.

Working on adding a paging control to GitHawk on the repo view. Would like to use the same control for profile when that gets worked on. Maybe even add this to Inbox too (tho it'll break the swipe-to-read feature).

I'm using Tabman atm, seems to be the best control I can find (best = no bugs, simple API). It also has an "inchworm" UI (where the slider line changes widths) which we built on IG once. Really cool detail!

I looked into PageMenu but it has an orientation-change bug that I don't feel like fixing. I started by using this control then removed it.

Also looked at XLPagerTabStrip but didn't try it out.

Anything major I'm missing? cc @BasThomas @rizwankce

@Sherlouk
Copy link
Member

Well this certainly helps me with the stuff in #335! And actually because of the way I've built my stuff it should slot in much nicer as it's already it's own VC

Will have a full look at this tonight, but on the face of it looks good

@rnystrom
Copy link
Member Author

I love that this lets us split apart the overview, issues, and other stuff into child VCs. MUCH cleaner architecture.

@Sherlouk
Copy link
Member

Yeah that's definitely an improvement! Would like to get projects on this sooner rather than later, any major changes coming up to make me wait?

@rnystrom
Copy link
Member Author

@Sherlouk issues/PR aren't done yet, and there's a content-inset bug. I should have this done + merged tonight tho. But you could rebase off of this now and start using it. Only major change would be if someone pointed out some jaw-dropping paging control that I missed. Doubt it tho.

@BasThomas
Copy link
Collaborator

BasThomas commented Sep 21, 2017

Awesome! FWIW, the try! Swift app is using the XLPagerTabStrip and it seems to work fine, but don’t really see a reason to switch if Tabman works OK 😃

@Sherlouk
Copy link
Member

Also with the new issue/pr pages should be a lot easier (and nicer UI) to add an open/closed switch!

Sent with GitHawk

@rizwankce
Copy link
Collaborator

Checked out Tabman and really liked the Tabman styles. Hope we don’t want to try any other control and stick with Tabman.

Sent with GitHawk

@rnystrom rnystrom changed the title [WIP] Repo paging control Repo paging control Sep 22, 2017
@rnystrom rnystrom merged commit 6912f76 into master Sep 22, 2017
@rnystrom rnystrom deleted the repo-paging branch September 22, 2017 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants