New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git command async #4

Closed

Ovyerus opened this issue Oct 7, 2017 · 2 comments

Labels

Collaborator

Ovyerus commented Oct 7, 2017

Because the git commands use regular subprocess stuff, using them freezes up the entire bot currently. Using asyncio subprocess would fix this.

Ovyerus added the enhancement label

Owner

Roadcrosser commented Oct 7, 2017

Because this involves grabbing stdout after everything is done, this relates to #3

Collaborator Author

Ovyerus commented Oct 9, 2017

Done in 8c14f57 and 1394259

Ovyerus closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment