Use render syntax and brackets for arrays

roadiz · Feb 25, 2015 · 6ab9282 · 6ab9282
1 parent 5abaec6
commit 6ab9282
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 48 deletions.
diff --git a/themes/create_theme.rst b/themes/create_theme.rst
@@ -179,11 +179,7 @@ multilingual pages.
         $translation = $this->bindLocaleFromRoute($request, 'en');
         $this->prepareThemeAssignation(null, $translation);
 
-        return new Response(
-            $this->getTwig()->render('foo.html.twig', $this->assignation),
-            Response::HTTP_OK,
-            array('content-type' => 'text/html')
-        );
+        return $this->render('foo.html.twig', $this->assignation);
     }
 
     public function barAction(
@@ -195,11 +191,7 @@ multilingual pages.
         $this->prepareThemeAssignation(null, $translation);
 
 
-        return new Response(
-            $this->getTwig()->render('bar.html.twig', $this->assignation),
-            Response::HTTP_OK,
-            array('content-type' => 'text/html')
-        );
+        return $this->render('bar.html.twig', $this->assignation);
     }
 
 .. _dynamic-routing:
@@ -238,11 +230,7 @@ render your current node.
 
         $this->getService('stopwatch')->start('twigRender');
 
-        return new Response(
-            $this->getTwig()->render('types/page.html.twig', $this->assignation),
-            Response::HTTP_OK,
-            array('content-type' => 'text/html')
-        );
+        return $this->render('types/page.html.twig', $this->assignation);
     }
 
 As *Symfony* controllers do, every Roadiz controllers actions have to return a valid ``Response`` object.
@@ -332,11 +320,7 @@ Imagine now that your home page has a totally different look than other pages. I
         /*
          * Render Homepage manually
          */
-        return new Response(
-            $this->getTwig()->render('home.html.twig', $this->assignation),
-            Response::HTTP_OK,
-            array('content-type' => 'text/html')
-        );
+        return $this->render('home.html.twig', $this->assignation);
     }
 
 Keep in ming that ``prepareThemeAssignation`` method will assign for you some useful variables no matter you choice

diff --git a/themes/custom_assignations.rst b/themes/custom_assignations.rst
@@ -24,9 +24,7 @@ create a *PageController.php* which look like this:
     use Themes\MyTheme\MyThemeApp;
     use RZ\Roadiz\Core\Entities\Node;
     use RZ\Roadiz\Core\Entities\Translation;
-
     use Symfony\Component\HttpFoundation\Request;
-    use Symfony\Component\HttpFoundation\Response;
 
     /**
      * Frontend controller to handle Page node-type request.
@@ -49,11 +47,7 @@ create a *PageController.php* which look like this:
         ) {
             $this->prepareThemeAssignation($node, $translation);
 
-            return new Response(
-                $this->getTwig()->render('types/page.html.twig', $this->assignation),
-                Response::HTTP_OK,
-                array('content-type' => 'text/html')
-            );
+            return $this->render('types/page.html.twig', $this->assignation);
         }
     }
 
@@ -119,9 +113,7 @@ Open your ``PageController.php`` file:
     // Get BasicBlock node-type entity to filter
     // over current node children
     $basicBlockType = $this->getService('nodeTypeApi')
-                           ->getOneBy(
-                                'name' => 'BasicBlock'
-                           );
+                           ->getOneBy(['name' => 'BasicBlock']);
 
     // Assign blocks using current nodeSource children
     // filtering them by node-type (only BasicBlock nodes
@@ -132,12 +124,12 @@ Open your ``PageController.php`` file:
         $this->assignation['nodeSource']
              ->getHandler()
              ->getChildren(
-                array(
+                [
                     'node.nodeType' => $basicBlockType
-                ),
-                array(
+                ],
+                [
                     'node.position' => 'ASC'
-                ),
+                ],
                 $this->getService('securityContext')
              );
 

diff --git a/themes/extending_roadiz.rst b/themes/extending_roadiz.rst
@@ -32,7 +32,6 @@ Example:
 
     use Themes\Rozier\RozierApp;
     use Symfony\Component\HttpFoundation\Request;
-    use Symfony\Component\HttpFoundation\Response;
     use Symfony\Component\HttpFoundation\RedirectResponse;
 
     class AdminController extends RozierApp
@@ -44,11 +43,7 @@ Example:
 
             $this->getService('stopwatch')->start('twigRender');
 
-            return new Response(
-                $this->getTwig()->render('admin/test.html.twig', $this->assignation),
-                Response::HTTP_OK,
-                array('content-type' => 'text/html')
-            );
+            return $this->render('admin/test.html.twig', $this->assignation);
         }
     }
 
@@ -126,13 +121,13 @@ or create it if it doesn’t exist.
             /*
              * Add a customAdmin entry in your Backoffice
              */
-            $entries['customAdmin'] = array(
+            $entries['customAdmin'] = [
                 'name' => 'customAdmin',
                 'path' => $c['urlGenerator']->generate('adminTestPage'),
                 'icon' => 'uk-icon-cube',
                 'roles' => null,
                 'subentries' => null
-            );
+            ];
 
             return $entries;
         });
@@ -148,21 +143,21 @@ If you want to have a category and sub-entries, just change the path at ``null``
 
 .. code-block:: php
 
-    $entries['customAdmin'] = array(
+    $entries['customAdmin'] = [
         'name' => 'customAdmin',
         'path' => null,
         'icon' => 'uk-icon-cube',
         'roles' => null,
-        'subentries' => array(
-            'customAdminPage' => array(
+        'subentries' => [
+            'customAdminPage' => [
                 'name' => 'customAdmin page',
                 'path' => $c['urlGenerator']->generate('adminTestPage'),
                 'icon' => 'uk-icon-cube',
                 'roles' => null
-            ),
+            ],
             // Add others if you want
-        )
-    );
+        ]
+    ];
 
 You can restrict buttons to users with specific roles. Just replace ``'roles' => null`` with
 ``'roles' => array('ROLE_ACCESS_NODES')``. You can even create your own roles to take full power of