Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Pub/Sub driver #68

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Add support for Google Pub/Sub driver #68

merged 4 commits into from
Jul 29, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Jul 14, 2024

Q A
Bugfix?
Breaks BC?
New feature? ✔️
Issues #roadrunner-php/issues#36

@msmakouz msmakouz added the enhancement New feature or request label Jul 14, 2024
@msmakouz msmakouz added this to the 4.x milestone Jul 14, 2024
@msmakouz msmakouz self-assigned this Jul 14, 2024
Copy link

coderabbitai bot commented Jul 14, 2024

Walkthrough

The recent changes introduce a new PubSubCreateInfo class to the Spiral\RoadRunner\Jobs\Queue namespace, which facilitates the creation of Pub/Sub job information. This class features properties for project ID, topic, dead letter topic, and max delivery attempts, along with a method to convert its information to an array. Additionally, a minor alteration in .styleci.yml involves removing the unary_operator_spaces rule from the enabled section.

Changes

File Change Summary
src/Queue/PubSubCreateInfo.php Added PubSubCreateInfo class with properties and methods to support Pub/Sub job information creation.
.styleci.yml Removed the unary_operator_spaces rule from the enabled section.

Poem

In fields of code where changes bloom, 🌸
A class for Pub/Sub finds its room.
With project, topic, attempts in view, 📜
Arrays transform our data true.
Style rules shift, but still we strive,
In Rabbit's world, our codes survive. 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msmakouz msmakouz marked this pull request as draft July 14, 2024 19:35
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (5a4c061) to head (af9965d).
Report is 5 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x      #68      +/-   ##
============================================
+ Coverage     87.25%   87.50%   +0.24%     
- Complexity      204      208       +4     
============================================
  Files            30       31       +1     
  Lines           620      632      +12     
============================================
+ Hits            541      553      +12     
  Misses           79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9842316 and af9965d.

Files selected for processing (3)
  • src/Queue/Driver.php (1 hunks)
  • src/Queue/PubSubCreateInfo.php (1 hunks)
  • tests/Unit/Queue/PubSubCreateInfoTest.php (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/Queue/Driver.php
Additional comments not posted (8)
src/Queue/PubSubCreateInfo.php (3)

1-7: LGTM!

The namespace and class declaration are standard.


9-28: LGTM!

The constants and constructor are well-defined with appropriate type hints and default values.


30-43: LGTM!

The toArray method is well-implemented and follows best practices for array conversion.

tests/Unit/Queue/PubSubCreateInfoTest.php (5)

1-10: LGTM!

The namespace and imports are standard for a PHPUnit test case.


13-31: LGTM!

The testCreatePubSubCreateInfo method is well-implemented and covers the necessary assertions.


33-48: LGTM!

The testCreatePubSubCreateInfoOnlyRequiredData method is well-implemented and covers the necessary assertions.


50-72: LGTM!

The testToArray method is well-implemented and covers the necessary assertions.


74-91: LGTM!

The testToArrayOnlyRequiredData method is well-implemented and covers the necessary assertions.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between af9965d and 16fdac9.

Files selected for processing (1)
  • src/Queue/PubSubCreateInfo.php (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/Queue/PubSubCreateInfo.php

@msmakouz msmakouz marked this pull request as ready for review July 18, 2024 10:28
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 16fdac9 and bf72e1a.

Files selected for processing (2)
  • .styleci.yml (1 hunks)
  • src/Queue/PubSubCreateInfo.php (1 hunks)
Files skipped from review due to trivial changes (1)
  • .styleci.yml
Files skipped from review as they are similar to previous changes (1)
  • src/Queue/PubSubCreateInfo.php

@msmakouz msmakouz merged commit 1df9702 into 4.x Jul 29, 2024
7 checks passed
@msmakouz msmakouz deleted the feat/pubsub branch July 29, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants