-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Google Pub/Sub driver #68
Conversation
msmakouz
commented
Jul 14, 2024
•
edited
Loading
edited
Q | A |
---|---|
Bugfix? | ❌ |
Breaks BC? | ❌ |
New feature? | ✔️ |
Issues | #roadrunner-php/issues#36 |
WalkthroughThe recent changes introduce a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #68 +/- ##
============================================
+ Coverage 87.25% 87.50% +0.24%
- Complexity 204 208 +4
============================================
Files 30 31 +1
Lines 620 632 +12
============================================
+ Hits 541 553 +12
Misses 79 79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/Queue/Driver.php (1 hunks)
- src/Queue/PubSubCreateInfo.php (1 hunks)
- tests/Unit/Queue/PubSubCreateInfoTest.php (1 hunks)
Files skipped from review due to trivial changes (1)
- src/Queue/Driver.php
Additional comments not posted (8)
src/Queue/PubSubCreateInfo.php (3)
1-7
: LGTM!The namespace and class declaration are standard.
9-28
: LGTM!The constants and constructor are well-defined with appropriate type hints and default values.
30-43
: LGTM!The
toArray
method is well-implemented and follows best practices for array conversion.tests/Unit/Queue/PubSubCreateInfoTest.php (5)
1-10
: LGTM!The namespace and imports are standard for a PHPUnit test case.
13-31
: LGTM!The
testCreatePubSubCreateInfo
method is well-implemented and covers the necessary assertions.
33-48
: LGTM!The
testCreatePubSubCreateInfoOnlyRequiredData
method is well-implemented and covers the necessary assertions.
50-72
: LGTM!The
testToArray
method is well-implemented and covers the necessary assertions.
74-91
: LGTM!The
testToArrayOnlyRequiredData
method is well-implemented and covers the necessary assertions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/Queue/PubSubCreateInfo.php (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/Queue/PubSubCreateInfo.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .styleci.yml (1 hunks)
- src/Queue/PubSubCreateInfo.php (1 hunks)
Files skipped from review due to trivial changes (1)
- .styleci.yml
Files skipped from review as they are similar to previous changes (1)
- src/Queue/PubSubCreateInfo.php