-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symfony/process 7.x #7
Conversation
msmakouz
commented
Dec 19, 2023
•
edited
Loading
edited
Q | A |
---|---|
Bugfix? | ❌ |
Breaks BC? | ❌ |
New feature? | ❌ |
Issue | roadrunner-php/issues#27 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 1.x #7 +/- ##
======================================
Coverage ? 86.46%
Complexity ? 50
======================================
Files ? 8
Lines ? 133
Branches ? 0
======================================
Hits ? 115
Misses ? 18
Partials ? 0 ☔ View full report in Codecov by Sentry. |
WalkthroughThe changes across the workflow files indicate a shift away from specifying PHP versions in the continuous integration process. This suggests a move to either a default PHP version provided by the runner environment or a strategy that does not require explicit versioning, possibly to streamline the workflows or to adapt to an updated CI environment. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- composer.json
Files selected for processing (3)
- .github/workflows/cs.yml (1 hunks)
- .github/workflows/phpunit.yml (1 hunks)
- .github/workflows/psalm.yml (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/cs.yml
- .github/workflows/psalm.yml
Additional comments: 1
.github/workflows/phpunit.yml (1)
- 12-16: The removal of the PHP version matrix and reliance on an external workflow (
spiral/gh-actions/.github/workflows/phpunit.yml@master
) for thephpunit
job suggests that the PHP version handling is now externalized. Verify that the external workflow is compatible with the project's requirements and that it supports the newly allowedsymfony/process
7.x version. Additionally, ensure that the external workflow is maintained and follows best practices for version pinning to avoid unexpected changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/phpunit.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/phpunit.yml