Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/process 7.x #7

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Allow symfony/process 7.x #7

merged 3 commits into from
Dec 19, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 19, 2023

Q A
Bugfix?
Breaks BC?
New feature?
Issue roadrunner-php/issues#27

@msmakouz msmakouz self-assigned this Dec 19, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (1.x@bd3c04e). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             1.x       #7   +/-   ##
======================================
  Coverage       ?   86.46%           
  Complexity     ?       50           
======================================
  Files          ?        8           
  Lines          ?      133           
  Branches       ?        0           
======================================
  Hits           ?      115           
  Misses         ?       18           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

coderabbitai bot commented Dec 19, 2023

Walkthrough

The changes across the workflow files indicate a shift away from specifying PHP versions in the continuous integration process. This suggests a move to either a default PHP version provided by the runner environment or a strategy that does not require explicit versioning, possibly to streamline the workflows or to adapt to an updated CI environment.

Changes

File Path Change Summary
.github/workflows/cs.yml
.github/workflows/psalm.yml
Removed PHP version specification for jobs running on Ubuntu and within the psalm.yml file.
.github/workflows/phpunit.yml Expanded PHP version matrix to include PHP 8.3.

Poem

In the realm of code, where the workflows stream,
A rabbit hopped by, with a coder's dream.
No versions to state, in the CI's embrace,
Just sleek lines of yaml, in a simpler space. 🐇💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between bd3c04e and 7dde60b.
Files ignored due to filter (1)
  • composer.json
Files selected for processing (3)
  • .github/workflows/cs.yml (1 hunks)
  • .github/workflows/phpunit.yml (1 hunks)
  • .github/workflows/psalm.yml (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/cs.yml
  • .github/workflows/psalm.yml
Additional comments: 1
.github/workflows/phpunit.yml (1)
  • 12-16: The removal of the PHP version matrix and reliance on an external workflow (spiral/gh-actions/.github/workflows/phpunit.yml@master) for the phpunit job suggests that the PHP version handling is now externalized. Verify that the external workflow is compatible with the project's requirements and that it supports the newly allowed symfony/process 7.x version. Additionally, ensure that the external workflow is maintained and follows best practices for version pinning to avoid unexpected changes.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7dde60b and 469e257.
Files selected for processing (1)
  • .github/workflows/phpunit.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/phpunit.yml

@rustatian rustatian added the enhancement New feature or request label Dec 19, 2023
@msmakouz msmakouz merged commit 1733f27 into 1.x Dec 19, 2023
11 checks passed
@msmakouz msmakouz deleted the sf-7 branch December 19, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants