Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for the nil client before attempting to send a request #78

Merged
merged 1 commit into from Feb 15, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Feb 15, 2024

Reason for This PR

  • Panic on superfast connect when RR is still initializing.

Description of Changes

  • Check the client for nil.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling for uninitialized clients in the RPC calls, providing a clear message to wait if the system is not ready yet.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added bug Something isn't working enhancement New feature or request labels Feb 15, 2024
@rustatian rustatian self-assigned this Feb 15, 2024
@rustatian rustatian merged commit 9ab4c43 into master Feb 15, 2024
4 checks passed
@rustatian rustatian deleted the fix/fast-connection branch February 15, 2024 16:12
Copy link

coderabbitai bot commented Feb 15, 2024

Walkthrough

The recent update enhances the system's resilience by adding error handling for scenarios where the RPC client is not yet initialized. It prevents premature RPC calls by checking if the client object is nil and, if so, advises waiting a bit longer with a friendly error message. This minor yet crucial change ensures smoother operation and user experience by avoiding unexpected failures when the system is still getting ready.

Changes

File Summary
rpc.go Introduced error handling for uninitialized client, advising to wait if "RoadRunner is not ready yet".

🐇✨
In the land of code where the bits roam free
A rabbit found an error, as clear as could be
"Wait," it said, "for the RoadRunner's pace,
Not yet ready, it needs some space.
So hold your requests, just give it a sec,
For smoother paths, without a speck."
🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 663641b and 308a764.
Files ignored due to path filters (1)
  • go.work.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • rpc.go (35 hunks)

rpc.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
1 participant