elapsed to Milliseconds

[dmitryuk]

Partly closes roadrunner-server/roadrunner#1858

Summary by CodeRabbit

• Refactor
  • Improved logging accuracy by converting time duration to milliseconds in key components.
  • Updated logging statements in listener.go related to job processing to include elapsed time in milliseconds.
  • Updated logging in plugin.go for job push errors and successes to include elapsed time as an integer.
  • Updated logging statement in worker_pool.go to include duration in milliseconds.

[coderabbitai]

Walkthrough

The recent updates to listener.go, plugin.go, and worker_pool.go files refine logging practices by consistently logging the "elapsed" time in milliseconds. This aligns with the request for logging time in a specific unit, enhancing monitoring and analysis capabilities across job processing and plugin functions.

Changes

Files	Change Summary
listener.go	Updated logging statements to include elapsed time in milliseconds using Int64 method.
plugin.go	Updated logging in Push and PushBatch functions to include elapsed time in milliseconds.
worker_pool.go	Updated logging statement to include duration in milliseconds using zap.Int64.

Assessment against linked issues

Objective	Addressed	Explanation
Log elapsed time always in microseconds (#1858)	❌	The changes log time in milliseconds, not microseconds as requested.

Poem

In the realm of code, where the rabbits hop,
We tweaked the logs, made the time units swap.
🕒 From microseconds, a leap to milliseconds we take,
A small step for code, a giant hop for clarity's sake.

🐇💻✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 10

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 1c78ce0 and db88a3b.

Files selected for processing (2)

• listener.go (7 hunks)
• worker_pool.go (1 hunks)

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between db88a3b and 7937a5e.

Files selected for processing (3)

• listener.go (7 hunks)
• plugin.go (2 hunks)
• worker_pool.go (1 hunks)

Additional comments: 13

worker_pool.go (1)

• 72-72: The update to log the elapsed time in milliseconds using zap.Int64("elapsed", time.Since(t).Milliseconds()) aligns well with the PR's objective to standardize elapsed time logging across the Roadrunner server. This change ensures consistency and improves the monitoring and analysis of log entries.

listener.go (9)

• 41-41: The update to log the elapsed time in milliseconds for job processing start is consistent with the PR's objective and improves the clarity of log entries for performance monitoring.
• 46-46: Logging the elapsed time in milliseconds for job marshal errors enhances the consistency and usefulness of error logs, aligning with the PR's goals.
• 67-67: Including the elapsed time in milliseconds for job processing errors is a valuable improvement, ensuring consistent and detailed error logging.
• 87-87: The update to log the elapsed time in milliseconds for job processing errors within the response handling block maintains consistency and aids in performance analysis.
• 107-107: Logging the elapsed time in milliseconds when streaming is not supported provides clear and consistent feedback for unsupported operations.
• 143-143: Including the elapsed time in milliseconds for acknowledge errors offers better insight into job processing timelines and potential delays.
• 149-149: The update to log the elapsed time in milliseconds for successful job processing aligns with the PR's goals, enhancing log clarity and consistency.
• 162-162: Logging the elapsed time in milliseconds for response handler errors improves error log consistency and provides valuable timing information.
• 183-183: The update to log the elapsed time in milliseconds for successfully processed jobs ensures consistent and clear logging, facilitating performance analysis.

plugin.go (3)

• 373-373: Updating the logging of job push errors to include the elapsed time in milliseconds is consistent with the PR's objective, enhancing the clarity and usefulness of error logs.
• 381-381: The change to log the elapsed time in milliseconds for successful job pushes aligns with the PR's goals, improving log consistency and facilitating performance analysis.
• 417-417: Including the elapsed time in milliseconds for batch job push errors enhances the consistency and usefulness of error logs, aligning with the PR's objectives.