Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: rpc stats wrong span name #92

Merged
merged 5 commits into from Jul 10, 2023

Conversation

Kaspiman
Copy link
Sponsor Contributor

@Kaspiman Kaspiman commented Jul 10, 2023

Reason for This PR

rpc stat has wrong span name

Description of Changes

EDIT: @Kaspiman (FIX is not a description):

  1. destroy_pipeline -> stat in the Stat method.
  2. acknowledgin -> acknowledging

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Plakhotnikov Vladimir and others added 5 commits June 8, 2023 11:09
Signed-off-by: Vladimir Plakhotnikov <embargo2710@gmail.com>
Signed-off-by: Vladimir Plakhotnikov <embargo2710@gmail.com>
@rustatian rustatian changed the title Rpc stats typo: rpc stats wrong span name Jul 10, 2023
@rustatian rustatian self-requested a review July 10, 2023 12:00
@rustatian rustatian added the enhancement New feature or request label Jul 10, 2023
Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustatian rustatian merged commit e9ede9b into roadrunner-server:master Jul 10, 2023
3 checks passed
@rustatian
Copy link
Member

@Kaspiman Thanks 👍🏻

P.S: Please, next time, use the proper pull request name and changelog description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
2 participants